[rcore] Use FLAG_* macros where possible
#5169
Conversation
JohnnyCena123
force-pushed
the
flag-macros
branch
from
3255f2b to
4fbf247
Compare
JohnnyCena123
force-pushed
the
flag-macros
branch
from
4fbf247 to
70a06f9
Compare
raysan5
changed the title
FLAG_* macros where possible
|
@JohnnyCena123 I've been thinking about this update and I'm merging it but I'm concerned about the macro So, code needs to be updated from: if (FLAG_CHECK(CORE.Window.flags, FLAG_WINDOW_MINIMIZED) > 0) { }to if (FLAG_IS_SET(CORE.Window.flags, FLAG_WINDOW_MINIMIZED)) { }or depending the case if (!FLAG_IS_SET(CORE.Window.flags, FLAG_WINDOW_MINIMIZED)) { }Please, could you review it? |
|
@JohnnyCena123 Did you see my previous message? I can implement it if you can't. |
sorry, I must've missed it. I will do that tomorrow if I remember |
|
@raysan5 i remembered! |
src/platforms/rcore_android.c
Outdated
| { | ||
| if ((FLAG_CHECK(source, AINPUT_SOURCE_JOYSTICK) == AINPUT_SOURCE_JOYSTICK) || | ||
| (FLAG_CHECK(source, AINPUT_SOURCE_GAMEPAD) == AINPUT_SOURCE_GAMEPAD)) | ||
| if ((FLAG_IS_SET(source, AINPUT_SOURCE_JOYSTICK) == AINPUT_SOURCE_JOYSTICK) || |
There was a problem hiding this comment.
Is it needed the extra == check if we already check for the flag set?
src/platforms/rcore_android.c
Outdated
| // Handle gamepad button presses and releases | ||
| if ((FLAG_CHECK(source, AINPUT_SOURCE_JOYSTICK) == AINPUT_SOURCE_JOYSTICK) || | ||
| (FLAG_CHECK(source, AINPUT_SOURCE_GAMEPAD) == AINPUT_SOURCE_GAMEPAD)) | ||
| if ((FLAG_IS_SET(source, AINPUT_SOURCE_JOYSTICK) == AINPUT_SOURCE_JOYSTICK) || |
There was a problem hiding this comment.
Is it needed the extra == check if we already check for the flag set?
There was a problem hiding this comment.
i probably missed that, i only searched for == 0
JohnnyCena123
force-pushed
the
flag-macros
branch
from
38410b5 to
a49f79b
Compare
No description provided.